Skip to content

Implement data type changes from tucana#874

Draft
Taucher2003 wants to merge 3 commits intomainfrom
871-implement-data-type-changes-from-tucana
Draft

Implement data type changes from tucana#874
Taucher2003 wants to merge 3 commits intomainfrom
871-implement-data-type-changes-from-tucana

Conversation

@Taucher2003
Copy link
Member

@Taucher2003 Taucher2003 commented Mar 9, 2026 •
edited
Loading

Closes #871

@Taucher2003 Taucher2003 self-assigned this Mar 9, 2026
@github-actions
Copy link

github-actions bot commented Mar 9, 2026 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2384581887

Status: Failed
Duration: 5 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/13491959737/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2384581887/test_report
Finished in 23.79 seconds (files took 12.47 seconds to load)
1346 examples, 65 failures
Line Coverage: 85.71% (4313 / 5032)
[TEST PROF INFO] Time spent in factories: 00:12.320 (38.14% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/13491959736/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2384581887/test_report
Finished in 22.79 seconds (files took 11.01 seconds to load)
1299 examples, 65 failures
Line Coverage: 84.99% (4145 / 4877)
[TEST PROF INFO] Time spent in factories: 00:12.010 (40.12% of total time)

rubocop

757 files inspected, no offenses detected

nicosammito
nicosammito requested changes Mar 9, 2026
View reviewed changes
db/structure.sql

ALTER SEQUENCE data_type_rules_id_seq OWNED BY data_type_rules.id;

CREATE TABLE data_types (
Copy link
Contributor

@nicosammito nicosammito Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a type representing the TS type definition, variant is mo longer needed.

db/structure.sql

ALTER SEQUENCE flow_settings_id_seq OWNED BY flow_settings.id;

CREATE TABLE flow_type_settings (
Copy link
Contributor

@nicosammito nicosammito Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a type representing a TS type and should link t o DataTypes in any sort

db/structure.sql Outdated
Comment on lines 223 to 224
Copy link
Contributor

@nicosammito nicosammito Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have ts type and also link to datatypes

db/structure.sql Outdated
Comment on lines 245 to 246
Copy link
Contributor

@nicosammito nicosammito Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

db/structure.sql Outdated
created_at timestamp with time zone NOT NULL,
updated_at timestamp with time zone NOT NULL,
return_type_id bigint,
generic_keys text[] DEFAULT '{}'::text[] NOT NULL,
Copy link
Contributor

@nicosammito nicosammito Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genericKeys can be removed

@Taucher2003 Taucher2003 force-pushed the 871-implement-data-type-changes-from-tucana branch from 14b234a to 632a2b9 Compare March 10, 2026 20:07
@Taucher2003 Taucher2003 force-pushed the 871-implement-data-type-changes-from-tucana branch from 632a2b9 to 5636400 Compare March 13, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicosammito nicosammito nicosammito approved these changes

Assignees

@Taucher2003 Taucher2003

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement data type changes from tucana

2 participants

@Taucher2003 @nicosammito